Ruby: Fix native extension loading for new RubyGems (Ruby 4.1+)#1281
Merged
Ruby: Fix native extension loading for new RubyGems (Ruby 4.1+)#1281
Conversation
Owner
Author
|
@composerinteralia does this look right to you? |
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
composerinteralia
approved these changes
Mar 3, 2026
Contributor
composerinteralia
left a comment
composerinteralia
left a comment
There was a problem hiding this comment.
Yeah, this is what some other gems have done as well 👍🏻. Sorry, I meant to open a PR with this but I forgot.
Owner
Author
|
Awesome, thanks for the quick reply! 🙏🏼 |
marcoroth
added a commit
that referenced
this pull request
Mar 4, 2026
Sadly the require change in #1281 is now causing the `require "herb"` locally to favor the locally installed herb gem over the local herb version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request changes the native extension loading from
require_relativetorequireto ensure compatibility with the latest RubyGems, which no longer installs native extensions into the gem'slib/directory by default. See ruby/rubygems#9240.Using
requireresolves the extension through$LOAD_PATH, which RubyGems populates with both thelib/and extension directories, so this works on both old and new versions of RubyGems.Resolves #1244